[Bugfix] Fix Can't instantiate abstract class DeepseekV32IndexerBackend#33052
Merged
vllm-bot merged 3 commits intovllm-project:mainfrom Jan 26, 2026
Merged
[Bugfix] Fix Can't instantiate abstract class DeepseekV32IndexerBackend#33052vllm-bot merged 3 commits intovllm-project:mainfrom
vllm-bot merged 3 commits intovllm-project:mainfrom
Conversation
…impl_cls Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
mergify
bot
added
deepseek
…impl_cls Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request aims to fix an issue related to DeepseekV32IndexerBackend not having an implementation for get_impl_cls. However, the current change introduces a duplicate and incorrect definition for get_builder_cls. Please review the specific comment for details.
…impl_cls Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
changed the title
Collaborator
Author
|
/cc @NickLucche PTAL. |
NickLucche
approved these changes
Jan 26, 2026
Collaborator
NickLucche
left a comment
NickLucche
left a comment
There was a problem hiding this comment.
Not sure how this went through CI..thanks for the fix @chaunceyjiang
chaunceyjiang
added
the
ready
robertgshaw2-redhat
approved these changes
Jan 26, 2026
apd10
pushed a commit
to apd10/vllm
that referenced
this pull request
Jan 31, 2026
…nd (vllm-project#33052) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…nd (vllm-project#33052) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #33050
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.